Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Gossip Scoring #1115

Merged
merged 10 commits into from
May 31, 2021
Merged

Enable Gossip Scoring #1115

merged 10 commits into from
May 31, 2021

Conversation

ec2
Copy link
Member

@ec2 ec2 commented May 25, 2021

Summary of changes
Changes introduced in this pull request:

  • Reintroduces and fixes GossipSub parameters.

Reference issue to close (if applicable)

Closes

Other information and links

@ec2 ec2 requested a review from a user May 25, 2021 15:15
@ec2 ec2 changed the title Ec2/enable gossip scoring Enable Gossip Scoring May 25, 2021
@cryptoquick
Copy link
Contributor

Nice! How would this fail if I were to test it?

@ec2
Copy link
Member Author

ec2 commented May 28, 2021

Nice! How would this fail if I were to test it?

Blocks come in with delay, DoS, etc...

creativcoder
creativcoder approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor

@creativcoder creativcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ec2 where does this improve things?

cryptoquick
cryptoquick suggested changes May 31, 2021
View reviewed changes
Copy link
Contributor

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor changes

node/forest_libp2p/src/gossip_params.rs Outdated Show resolved Hide resolved
node/forest_libp2p/src/behaviour.rs Outdated Show resolved Hide resolved
node/forest_libp2p/src/behaviour.rs Outdated Show resolved Hide resolved
node/forest_libp2p/src/gossip_params.rs Show resolved Hide resolved
@ec2 ec2 requested a review from cryptoquick May 31, 2021 15:13
cryptoquick
cryptoquick approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Hopefully this will reduce those warnings we sometimes get, and just generally make us better at scoring peers with libp2p. 🚀

@ec2 ec2 merged commit a8931e2 into main May 31, 2021
@ec2 ec2 deleted the ec2/enable-gossip-scoring branch May 31, 2021 15:43
This was referenced Jun 9, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptoquick cryptoquick cryptoquick approved these changes

@creativcoder creativcoder creativcoder approved these changes

@connormullett connormullett Awaiting requested review from connormullett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ec2 @cryptoquick @creativcoder