Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix:fix passphrase fake confirm #1168

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

detailyang
Copy link
Contributor

@detailyang detailyang commented Jun 15, 2021

Signed-off-by: detailyang detailyang@gmail.com

Summary of changes
Fix the problem of inconsistent passwords when confirm the password:)

Reference issue to close (if applicable)

Closes

Other information and links

Signed-off-by: detailyang <detailyang@gmail.com>
Copy link
Member

@ec2 ec2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@cryptoquick
Copy link
Contributor

Screenshot from 2021-06-15 09-00-57
Technically we already "incorrect passphrase" as an error. I'm not sure if we want a duplicate message?

@cryptoquick
Copy link
Contributor

wait, nevermind, I just realized this is for when configuring a new keystore

Copy link
Contributor

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, crap, yeah, the behavior we currently have is broken. Definitely a good catch!

@cryptoquick cryptoquick merged commit f07f027 into ChainSafe:main Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants