hotfix:metrics:change prometheus response type #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More detail see https://github.com/prometheus/docs/blob/master/content/docs/instrumenting/exposition_formats.md#text-based-format Signed-off-by: detailyang <detailyang@gmail.com>
detailyang
requested review from
connormullett,
creativcoder,
cryptoquick and
ec2
as code owners
ghost
reviewed
Jun 15, 2021
cryptoquick
approved these changes
Jun 15, 2021
ghost
suggested changes
Jun 18, 2021
|
Done. Sorry for late reply. I'm busying working for actorv5 interopnet to forest:) |
|
@detailyang I like your fix! |
ghost
approved these changes
Jun 22, 2021
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Change prometheus response body type to text/format (default is application/octet-stream)
More detail see https://github.com/prometheus/docs/blob/master/content/docs/instrumenting/exposition_formats.md#text-based-format
Signed-off-by: detailyang detailyang@gmail.com
Reference issue to close (if applicable)
Closes
Other information and links