Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wallet verify #1170

Merged
merged 3 commits into from
Jun 16, 2021
Merged

fix wallet verify #1170

merged 3 commits into from
Jun 16, 2021

Conversation

connormullett
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • This is more of a bugfix. When refactoring the wallet cli when that PR was in review, a tuple construction was moved to another module to clean up the original file. The first two parameters of that tuple were strings and messed with the API. The address was actually a message, and a message was actually an address. All fixed now

Reference issue to close (if applicable)

Closes

Other information and links

Copy link
Contributor

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you figured that out!

Copy link
Member

@ec2 ec2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@connormullett connormullett merged commit d144eac into main Jun 16, 2021
@connormullett connormullett deleted the connor/walet-verify-fix branch June 16, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants