FIP 0008 Batch Pre Commits #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec2
requested review from
connormullett,
creativcoder and
cryptoquick
as code owners
ghost
reviewed
Jul 13, 2021
ghost
approved these changes
Jul 21, 2021
There was a problem hiding this comment.
LGTM, although I'd like to run this on a branch that synchronizes the state tree with the rest of the Network Version #13 changes.
Since NV13 is already live, is there anywhere I can look to see how these changes impact network congestion or miner costs?
|
Agreed, this would be easier to review if it wasn't in separate PRs, imo. What branch syncs for you, @ec2 ? |
|
@olibearo @cryptoquick You will be able to sync with |
cryptoquick
suggested changes
Aug 12, 2021
There was a problem hiding this comment.
Reviewed against changes in PRs linked here:
#1106 (comment)
Needs a few changes, some minor, some might be actual oversights.
cryptoquick
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #1106
Other information and links