Reference files with PathBuf instead of Strings #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leviathanbeak
requested review from
connormullett,
creativcoder,
cryptoquick and
ec2
as code owners
cryptoquick
approved these changes
Jul 29, 2021
cryptoquick
suggested changes
Jul 29, 2021
There was a problem hiding this comment.
Oh, one thing. Looks like this broke the linter. It made some good points. Can you take a look at the following issues?
https://app.circleci.com/pipelines/github/ChainSafe/forest/4930/workflows/c2328c6f-b6ed-43bf-afca-65ffd218ed4d/jobs/20505/parallel-runs/0/steps/0-111
|
@cryptoquick thanks for the review, and thank you clippy for suggestions, updated it |
cryptoquick
approved these changes
Jul 29, 2021
connormullett
approved these changes
Aug 2, 2021
|
@leviathanbeak Thanks again for your contributions. Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #1158