[Audit fixes] FOR-03 - Inconsistent Deserialization of Randomness #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptoquick
requested review from
connormullett,
creativcoder and
ec2
as code owners
|
LGTM. I just need to verify against my node. Still figuring out a panic in the proofs library. |
connormullett
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #1135
Other information and links
It's not a great solution, but Lotus kinda backed us into this. As long as this doesn't cause any consensus issues, this solution should be fine. I'm not sure if this is the best approach, but it's a solution. Feel free to pick it apart or close it if there's a better way to resolve the audit finding.