Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audit fixes] FOR-09 - Inconsistent Beacon Validation Across Forks #1206

Merged
merged 5 commits into from
Sep 28, 2021

Conversation

cryptoquick
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Return Ok when validating drand beacon entries similar to how Lotus does as per the audit recommendation.

Reference issue to close (if applicable)

Closes #1141

Other information and links

@ec2
Copy link
Member

ec2 commented Aug 18, 2021

LGTM. I just need to verify against my node. Still figuring out a panic in the proofs library.

Copy link
Contributor

@connormullett connormullett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ec2 ec2 merged commit ccf1ac1 into main Sep 28, 2021
@ec2 ec2 deleted the hunter/1141-FOR-09 branch September 28, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FOR-09: Inconsistent Beacon Entry Validation Across Forks
3 participants