Rest of V5 Updates #1217
Rest of V5 Updates #1217
Conversation
ec2
added
Status: Needs Review
Actor
ec2
requested review from
connormullett,
creativcoder and
cryptoquick
as code owners
|
@ec2 Can you link to a lotus git diff I can compare this against? |
|
Also, you failed the linter :/ |
There was a problem hiding this comment.
Everything looks consistent with the go specs actors changes, but I added a couple documentation updates you missed in a PR into this branch:
#1224
Take a look, feel free to merge if it's helpful.
* Add missing comments in market actor. * Add missing comments in market state.
| @@ -71,12 +71,24 @@ use super::{BitField, Result}; | |||
| use serde::{Deserialize, Deserializer, Serialize, Serializer}; | |||
| use std::borrow::Cow; | |||
|
|
|||
| // MaxEncodedSize is the maximum encoded size of a bitfield. When expanded into | |||
| // a slice of runs, a bitfield of this size should not exceed 2MiB of memory. | |||
There was a problem hiding this comment.
@olibearo I believe it says runs, which I think makes sense in this context
There was a problem hiding this comment.
(assuming RLE stands for Run-Length Encoding)
|
Your Name seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Summary of changes
Changes introduced in this pull request:
This PR includes the following:
Here is the specs-actor PR for changes in
vm/actor/src/builtin/verifreg/mod.rs: feat: Allow VerifiedClient DataCap to be topped up filecoin-project/specs-actors#1390vm/actor/src/builtin/market/: Clarify market actor sector termination with expired deals filecoin-project/specs-actors#1417Reference issue to close (if applicable)
Closes
Other information and links