-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connor/state cli #1219
Merged
Merged
Connor/state cli #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change is because of implementation limitation in state_manager
connormullett
requested review from
creativcoder,
cryptoquick and
ec2
as code owners
August 26, 2021 21:58
ec2
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on mainnet. Looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
state
to forest with 4 different subcommands to query chain state.Note that
state power
is not able to query solely network power due to forest specific implementation ofget_power
within the state manager. The current implementation of the command only allows for querying a miner's claimed power compared to the network's power.state get-actor
currently does not display the actor's name by code. This is being implemented currently and will be tracked in a new ticket to push the rest of the state commands to expedite the review process.Reference issue to close (if applicable)
Closes #541
Other information and links
actor_name_by_code v4 implementation PR #1218