Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circleci: prepare build matrix #1233

Merged
merged 7 commits into from
Sep 28, 2021
Merged

circleci: prepare build matrix #1233

merged 7 commits into from
Sep 28, 2021

Conversation

q9f
Copy link
Contributor

@q9f q9f commented Sep 28, 2021

  • renamed test-executor to linux-executor
  • updated linux-executor image to ubuntu-2004:202107-02
  • renaned mac-executor to macos-executor
  • updated xcode version to 13.0.0
  • renamed install_rust command to install_rust_linux
  • added install_rust_macos command
  • renamed rust_setup to set_rustc_stable
  • added set_rustc_nightly
  • added linux-build-stable job
  • renamed nightly-build-check job to linux-build-nightly
  • renamed msrv-build-check job to linux-build-msrv
  • renamed macos-build-check job to macos-build-stable
  • renamed setup_test to test-checks
  • renamed build-check to build-checks
  • renamed daily-checks to nightly-checks
  • removed todos and unused stuff and stuff we shouldn't ignore

@q9f q9f marked this pull request as ready for review September 28, 2021 13:14
@q9f q9f requested a review from a user September 28, 2021 13:14
Copy link
Member

@ec2 ec2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we need the MacOS build tests 🤔

@q9f
Copy link
Contributor Author

q9f commented Sep 28, 2021

Not sure if we need the MacOS build tests thinking

Yesterday you said, you don't know if it's building on macos.

I can also remove macos nightly and just keep stable. But one job on macos should be in place, don't you think?

@ec2
Copy link
Member

ec2 commented Sep 28, 2021

Not sure if we need the MacOS build tests thinking

Yesterday you said, you don't know if it's building on macos.

I can also remove macos nightly and just keep stable. But one job on macos should be in place, don't you think?

Yeah, I would remove MacOS Nightly and we can keep the stable build.

Copy link
Member

@ec2 ec2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just remove MacOS nightly as discussed.

@q9f
Copy link
Contributor Author

q9f commented Sep 28, 2021

I removed mac nightly in 33c0603 and decided to restore msrv of 1.52.1 for now.

@q9f q9f merged commit 70f26c2 into main Sep 28, 2021
@q9f q9f deleted the q9f/circle/matrix branch September 28, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants