Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elmattic/actors review f20 #1322

Merged
merged 2 commits into from
Dec 9, 2021
Merged

Elmattic/actors review f20 #1322

merged 2 commits into from
Dec 9, 2021

Conversation

elmattic
Copy link
Contributor

@elmattic elmattic commented Dec 8, 2021

Summary of changes
Changes introduced in this pull request:

  • Move validation code out of the for_each loop

Reference issue to close (if applicable)

Closes #1286

Other information and links

Note this still doesn't match exactly one for one Go actor logic. E.g. if we return at this point we never touch the state since we update it afterwards. In contrary Go actor updates the state in the for_each loop.

@elmattic elmattic requested a review from a user December 8, 2021 17:45
Copy link

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems correct to me. Note this is a somewhat cosmetic fix -- if validate state fails, the chain halts (and so a subtle distinction between how Go and Rust behaved is immaterial).

Also note that this is only called by Cron, so gas is irrelevant (cron is gasless).

@noot noot merged commit 0328579 into main Dec 9, 2021
@noot noot deleted the elmattic/actors-review-F20 branch December 9, 2021 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F20: Operations performed out-of-order in ExpirationQueue::reschedule_all_as_faults
3 participants