Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elmattic/actors review f27 #1328

Merged
merged 3 commits into from
Dec 15, 2021
Merged

Elmattic/actors review f27 #1328

merged 3 commits into from
Dec 15, 2021

Conversation

elmattic
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Fix missing actor version check for a given network version
  • Update doc comments for network version

Reference issue to close (if applicable)

Closes #1304

Other information and links

Lotus can also fail in the predicate here. In Forest I think this is not really possible because all cases of an enum are checked.

Copy link
Contributor

@noot noot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@noot noot merged commit b29e873 into main Dec 15, 2021
@noot noot deleted the elmattic/actors-review-F27 branch December 15, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F27: DefaultRuntime::create_actor missing network version checks
2 participants