drand v14 update: fix fetching around null tipsets #1339
Conversation
|
|
||
| for _ in 0..20 { | ||
| let cbe = rand_ts.blocks()[0].beacon_entries(); | ||
| for v in cbe.iter() { |
| let cbe = rand_ts.blocks()[0].beacon_entries(); | ||
| for v in cbe.iter() { | ||
| if v.round() == round as u64 { | ||
| return Ok(v.clone()); |
There was a problem hiding this comment.
How costly is it to return by value here? (will depend of the size of the Vec inside BeaconEntry struct). Lotus returns a pointer on his side.
There was a problem hiding this comment.
I think it's a fixed size of 32 bytes, so never mind.
There was a problem hiding this comment.
ok! let me know if you want me to change this, maybe there is a better way to do it
| let search_height = if round < 0 { 0 } else { round }; | ||
|
|
||
| let res = self.cs.tipset_by_height(search_height, ts, lookback).await; | ||
| match res { |
There was a problem hiding this comment.
Can use map_err here for more idiomatic code
| entropy: &[u8], | ||
| ) -> Result<[u8; 32], Box<dyn std::error::Error>> { | ||
| let chain_rand = ChainRand::new(blocks.to_owned(), self.cs.clone(), self.beacon.clone()); | ||
| match self.get_network_version(round) { |
There was a problem hiding this comment.
Would be better to match explicitly all cases of the enum instead of relying on the wildcard pattern (_).
Rational: if we introduce a new network version (e.g. NetworkVersion::V15), this would fall silently into get_beacon_randomness_v1 which is probably not what we want. Would be better that the code do not compile and be forced to inspect and handle the new case.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #1291
Other information and links