Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix encoding size constraints for BigInt and BigUint not enforced #1367

Merged
merged 3 commits into from
Jan 21, 2022
Merged

Fix encoding size constraints for BigInt and BigUint not enforced #1367

merged 3 commits into from
Jan 21, 2022

Conversation

elmattic
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Add size checks for both serialization and deserialization of BigInt and BigUint
  • Add corresponding tests

Reference issue to close (if applicable)

Closes #1331

Other information and links

@elmattic elmattic requested a review from lemmih as a code owner January 17, 2022 15:31
@q9f
Copy link
Contributor

q9f commented Jan 20, 2022

Please rebase on main.

@q9f q9f merged commit 1c385e4 into main Jan 21, 2022
@q9f q9f deleted the elmattic/actors-review-C3 branch January 21, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmih lemmih lemmih approved these changes

@noot noot noot approved these changes

@connormullett connormullett Awaiting requested review from connormullett

@ec2 ec2 Awaiting requested review from ec2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C3: BigInt and BigUint do not enforce encoded size constraints
4 participants
@elmattic @q9f @lemmih @noot