Elmattic/actors review c1 #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noot
reviewed
Jan 14, 2022
| // a slice of runs, a bitfield of this size should not exceed 2MiB of memory. | ||
| // | ||
| // This bitfield can fit at least 3072 sparse elements. | ||
| const MAX_ENCODED_SIZE: usize = 32 << 10; |
There was a problem hiding this comment.
why not 1 << 15? i assume there is a reason, just curious!
There was a problem hiding this comment.
This is a copy pasta of the way go-bitfield defines the constant.
filecoin-project/go-bitfield@3478657
I guess they write it like this to make 32KiB more visible :)
noot
approved these changes
Jan 14, 2022
|
Please rebase on |
elmattic
force-pushed
the
elmattic/actors-review-C1
branch
from
4b19a56
to
b2fd311
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
BitFieldUnvalidatedBitFieldUnvalidatedBitFieldand corresponding testReference issue to close (if applicable)
Closes #1329, #1330
Other information and links