Implement memory db #137
Merged
Implement memory db #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
force-pushed
the
austin/db/mem
branch
from
9ade150
to
3e625ab
Compare
austinabell
requested review from
GregTheGreek,
ansermino,
dutterbutter and
ec2
GregTheGreek
approved these changes
Jan 8, 2020
ec2
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed how the database open works with RocksDB so that the usage is more consistent among both. The way it works now is that either DB can be constructed in their own way and then open can be called on a mutable database to instantiate it.
The RocksDb struct can now be of an enum with just a Path buffer or of an instantiated database. Once started it will transition from the unopened to opened state, where it will be able to be interacted with. The memory db does not require to be opened, but will not error out if that function is called in some sort of end to end test since it also implements the DatabaseSerive trait.
Some of this might be confusing so I will try to read over to simplify or explain anything that doesn't make sense.