Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused lint exceptions. #1385

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Remove unused lint exceptions. #1385

merged 3 commits into from
Jan 20, 2022

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Jan 17, 2022

Summary of changes
Changes introduced in this pull request:

  • Remove lint exceptions for absurd_extreme_comparisons, suspicious_op_assign_impl, unreachable_code, unused_variables, and clippy::all.

Reference issue to close (if applicable)

The remaining lint exceptions are related to style rather than correctness (eg. clippy::too_many_arguments and clippy::type_complexity).

Other information and links

@elmattic
Copy link
Contributor

Just a question on the removal of those lint exceptions. If I understand correctly those exceptions were out of date?
It doesn't have been disable because of some removal of clippy lints?

I would rather have all possible checks and lints done, for exemple those kind of code should raise a red flag (suspicious_op_assign_impl):

impl AddAssign for Foo {
    fn add_assign(&mut self, other: Foo) {
        *self = *self - other;
    }
}

@lemmih
Copy link
Contributor Author

lemmih commented Jan 18, 2022

Yes, removing the exceptions means more lints are checked. The suspicious_op_assign_impl lint is enabled by default but was manually suppressed. Fortunately none of the correctness-related lint exceptions are required anymore and could just be removed.

@lemmih
Copy link
Contributor Author

lemmih commented Jan 19, 2022

Why does it believe I haven't signed the CLA?

@q9f q9f merged commit 13095e2 into main Jan 20, 2022
@q9f q9f deleted the lemmih/remove-clippy-exceptions branch January 20, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants