fix 1369 #1397
Merged
fix 1369 #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeslau
requested review from
connormullett,
ec2,
elmattic,
lemmih and
noot
as code owners
lemmih
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This is to fix the issue #1369, a test case issue.
This test fails randomly because in optimal message selection, there is a shuffling at L373. Further at line L412, there is a trim message chain operation. When performing
trim_msgs_atand deriving the prev, when idx == 0, prev should equal to None, but instead returned from the function. By chance that the caller passes idx == 0 to the function, then the chain is not trimed and should havevalidbeing false but instead true.Reference issue to close (if applicable)
Closes #1369
Other information and links