Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include network in forest version string. #1401

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Jan 26, 2022

Summary of changes
Changes introduced in this pull request:

  • Include network (eg. mainnet or devnet) in the version string shown with forest --version.

Reference issue to close (if applicable)

Other information and links

Target network is selected at compile time but the forest executable couldn't show which network had been selected.

Copy link
Contributor

@q9f q9f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not disagree with having this as part of the version string as long as this is a compile-time feature.

Copy link
Contributor

@connormullett connormullett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@q9f q9f merged commit ae2935b into main Jan 26, 2022
@q9f q9f deleted the lemmih/network-version-tag branch January 26, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants