Update address for network config, clean auxiliary stuff #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
austinabell
commented
Jan 10, 2020
austinabell
commented
- Updates address to include network as defined by updated spec
- network still not encoded in bytes or cbor as defined in spec or lotus implementation for some reason (won't update to include specifying network in function signatures because it could either be setup with some global or configured config variable)
- Adds license headers missing from previous PRs (PRs I had done before the license header came in and didn't add before those were merged)
- Changes blake2b encoding functions to more usable function (allows other data inputs other than vector)
austinabell
requested review from
ansermino,
dutterbutter,
ec2 and
GregTheGreek
dutterbutter
approved these changes
Jan 10, 2020
ansermino
reviewed
Jan 13, 2020
ansermino
approved these changes
Jan 13, 2020
|
LGTM |
ec2
reviewed
Jan 15, 2020
ec2
approved these changes
Jan 15, 2020
|
@ec2 @dutterbutter @ansermino good with updates since review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.