-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented block format #149
Conversation
* Implements block format for block and message writes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add a lib.rs
file and also include this crate in the root Cargo.toml if intended to keep this as seperate crate. Why is this not included in the blocks crate by the way? If it is intended to be seperate, the file that the block header is defined in should be changed from block.rs to block_header.rs or something to that effect.
My main reasoning for keeping it separated from blocks crate it that it mimics the external library used in the lotus implementation and if we wanted to pull it out into its own lib it would be easy. However, I am impartial and can move it into the blocks crate, but will rename it to |
* Moved blk format trait into block.rs * Removed BasicBlock and applied trait to full block
Moved |
Go Library of Block Format:
See usage examples in implementations here:
Closes #147