Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use exports from ref-fvm #1495

Merged
merged 3 commits into from Mar 24, 2022
Merged

use exports from ref-fvm #1495

merged 3 commits into from Mar 24, 2022

Conversation

LesnyRumcajs
Copy link
Member

Summary of changes
Changes introduced in this pull request:

  • used some exports from ref-fvm (from here plus some others on top of it), reducing code duplication a bit

Reference issue to close (if applicable)

Closes #1492

Other information and links

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #1495 (1220f6a) into main (cf49ba7) will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1495      +/-   ##
==========================================
+ Coverage   44.30%   44.40%   +0.10%     
==========================================
  Files         323      319       -4     
  Lines       28414    28231     -183     
==========================================
- Hits        12588    12537      -51     
+ Misses      15826    15694     -132     
Impacted Files Coverage Δ
types/src/genesis/mod.rs 0.00% <ø> (ø)
types/src/lib.rs 57.14% <ø> (ø)
types/src/sector/post.rs 27.27% <ø> (ø)
blockchain/message_pool/src/msg_chain.rs 80.24% <0.00%> (-0.41%) ⬇️
vm/actor/src/builtin/miner/mod.rs 33.49% <0.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf49ba7...1220f6a. Read the comment docs.

types/src/lib.rs Outdated Show resolved Hide resolved
types/src/sector/mod.rs Outdated Show resolved Hide resolved
types/src/sector/mod.rs Outdated Show resolved Hide resolved
@lemmih
Copy link
Contributor

lemmih commented Mar 23, 2022

Always great to see a PR that deletes a huge chunk of code. :)

@lemmih lemmih merged commit af62a43 into main Mar 24, 2022
@lemmih lemmih deleted the 1492-remove-duplicates branch March 24, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicates types in forest.
3 participants