Wrap Signature into a struct #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec2
requested review from
ansermino,
austinabell and
dutterbutter
as code owners
austinabell
suggested changes
Jan 21, 2020
crypto/src/signature.rs
Outdated
Comment on lines
27
to
33
| impl Deref for Signature { | ||
| type Target = Vec<u8>; | ||
|
|
||
| fn deref(&self) -> &Self::Target { | ||
| &self.0 | ||
| } | ||
| } |
There was a problem hiding this comment.
This is what I would do as well, but just to give the other option:
impl Signature {
pub fn as_bytes(&self) -> &Vec<u8> {
&self.0
}
}
Which seperates the functions on Signature with Vec. But since there seems to be nothing specific to signature and nothing to hide from signature this is probably good.
austinabell
approved these changes
Jan 21, 2020
dutterbutter
approved these changes
Jan 21, 2020
austinabell
changed the title
|
@dutterbutter if you don't mind rereviewing (and @ec2) from 26165cc changes. Don't worry I have Eric's blessing to push to his branch the serialization was missing the signature type :) |
dutterbutter
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before Signature was a type alias to
Vec<u8. This doesnt allow us to write a custom Serialize and Derserialize on it. So we need to wrap it in a struct.