DagCBOR encoding and decoding for Tickets #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec2
requested review from
ansermino,
austinabell and
dutterbutter
as code owners
austinabell
suggested changes
Jan 22, 2020
austinabell
reviewed
Jan 22, 2020
austinabell
reviewed
Jan 22, 2020
austinabell
reviewed
Jan 22, 2020
austinabell
reviewed
Jan 22, 2020
blockchain/blocks/src/ticket.rs
Outdated
Comment on lines
68
to
75
| pub struct CborEPostTicket( | ||
| #[serde(with = "serde_bytes")] Vec<u8>, // partial | ||
| u64, // sector_id | ||
| u64, // challenge_index | ||
| ); | ||
|
|
||
| #[derive(Serialize, Deserialize)] | ||
| pub struct CborEPostProof( |
There was a problem hiding this comment.
make these private, only used in this file for serialization
austinabell
approved these changes
Jan 22, 2020
dutterbutter
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links