Sync & Store methods updated #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added logic for validating msg data * Added message storage * Made raw block its own crate and impl to messages
* Updated raw block trait to improve cid return and remove multihash * Updated error returns * Added comments
* Updated error names
dutterbutter
requested review from
ansermino,
austinabell and
ec2
as code owners
austinabell
suggested changes
Jan 24, 2020
austinabell
reviewed
Jan 25, 2020
austinabell
suggested changes
Jan 27, 2020
* Updated RawBlock trait * Init DB instance on chain store construction
austinabell
reviewed
Jan 27, 2020
austinabell
approved these changes
Jan 27, 2020
ec2
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
raw_blockto its own crate and implemented it forMessagesfor storagemultihashfrom trait and updated CID returnvalidate_msg_dateput_messagefor storing message data in raw block formatadd_tipset_trackerfor updatingTipIndexstructurechain_storeconstructorReference issue to close (if applicable)
compute_msg_datais incomplete but dependant on AMT so will create new issue accordingly)Other information and links
The
compute_msg_datais temporary until the AMT is finished. See Lotus reference