Migration to Stable Futures and Network Refactor #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecause of dependancies. easy fix, but gotta go home
ec2
requested review from
ansermino,
austinabell and
dutterbutter
as code owners
|
|
austinabell
suggested changes
Feb 3, 2020
dutterbutter
suggested changes
Feb 4, 2020
| let peer_id = PeerId::from(net_keypair.public()); | ||
|
|
||
| info!(log, "Local peer id: {:?}", peer_id); | ||
|
|
||
| let transport = build_transport(net_keypair.clone()); | ||
|
|
||
| let mut swarm = { | ||
| let be = MyBehaviour::new(log.clone(), &net_keypair); | ||
| let be = ForestBehaviour::new(log.clone(), &net_keypair); | ||
| Swarm::new(transport, be, peer_id) | ||
| }; | ||
|
|
There was a problem hiding this comment.
Although not changed in this PR, should we avoid unwrapping on Swarm::listen_on on LN 86 (below).
I don't see why Github does not allow to comment on code unchanged in pr reviews, saw it being requested here as a feature interestingly.
There was a problem hiding this comment.
I feel like yall commented on it last time. And I don’t see how you can handle that kinda error. If you cant even listen_on, we shouldn’t handle that
austinabell
approved these changes
Feb 4, 2020
dutterbutter
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
networkcrateReference issue to close (if applicable)
Closes
#142
Other information and links