Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audit to CI #213

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Add audit to CI #213

merged 1 commit into from
Feb 4, 2020

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Adds audit to CI to check for vulnerable dependencies
    • Only runs on changes to any cargo file (don't want to slow the CI by running on any change)
  • Updates libsecp256k1 dependency because of vulnerability

Reference issue to close (if applicable)

Closes

Other information and links

@ansermino
Copy link
Member

We should make this a required check

@austinabell
Copy link
Contributor Author

austinabell commented Feb 4, 2020

We should make this a required check

I would rather not make it required because an audit could be unrelated to changes, they can just be fixed in parallel and not hold up the CI for PRs coming in.

Edit: But also happy to have it required if we agree on that, just didn't make sense to me

@austinabell austinabell merged commit 75224a6 into master Feb 4, 2020
@austinabell austinabell deleted the austin/auditci branch February 4, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants