Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Validation Checks - Message, Timestamp and Block Sig #219

Merged
merged 14 commits into from
Feb 11, 2020
Merged

Initial Validation Checks - Message, Timestamp and Block Sig #219

merged 14 commits into from
Feb 11, 2020

Conversation

dutterbutter
Copy link
Contributor

@dutterbutter dutterbutter commented Feb 9, 2020 •
edited

Summary of changes
Changes introduced in this pull request:

  • Added initial block validation checks
  • Specifically, messages validation check to ensure valid state transitions, timestamp checks, and block signature checks
  • Added required_funds method to Message type
  • Added check_block_signature method to BlockHeader type

Reference issue to close (if applicable)

Closes #212

Other information and links

Validation links used for reference:

@dutterbutter
Added check msg function
ac95597 
* Added message check
* Added required funds method to message trait
* Added sequence and balance methods to actor state
@dutterbutter
check msg implemented
ae1fce5 
* Added check message functionality for message validation
* Included block validation function to be refactored
@dutterbutter
Added initial block validation
1771401 
* Added initial validation checks
* timestamp check
* message state transition checks
* updated error
@dutterbutter
Added comment
5f064ea
@dutterbutter dutterbutter changed the title Initial Validation Checks Initial Validation Checks - Message Check and Timestamp Feb 9, 2020
@dutterbutter dutterbutter changed the title Initial Validation Checks - Message Check and Timestamp Initial Validation Checks - Message and Timestamp Feb 9, 2020
@dutterbutter dutterbutter changed the title Initial Validation Checks - Message and Timestamp Initial Validation Checks - Message, Timestamp and Block Sig Feb 9, 2020
austinabell
austinabell suggested changes Feb 9, 2020
View reviewed changes
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments but looks good !

blockchain/sync_manager/src/sync.rs Outdated Show resolved Hide resolved
blockchain/sync_manager/src/sync.rs Outdated Show resolved Hide resolved
blockchain/sync_manager/src/sync.rs Outdated Show resolved Hide resolved
blockchain/sync_manager/src/sync.rs Outdated Show resolved Hide resolved
blockchain/sync_manager/src/sync.rs Outdated Show resolved Hide resolved
blockchain/sync_manager/src/sync.rs Outdated Show resolved Hide resolved
blockchain/sync_manager/src/sync.rs Outdated Show resolved Hide resolved
blockchain/sync_manager/src/sync.rs Outdated Show resolved Hide resolved
blockchain/sync_manager/src/sync.rs Outdated Show resolved Hide resolved
blockchain/sync_manager/src/sync.rs Outdated Show resolved Hide resolved
ansermino
ansermino reviewed Feb 10, 2020
View reviewed changes
blockchain/blocks/src/header.rs Show resolved Hide resolved
blockchain/sync_manager/src/sync.rs Outdated Show resolved Hide resolved
blockchain/sync_manager/src/sync.rs Show resolved Hide resolved
austinabell
austinabell approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just added a few comments on things that would be nice to have updated

blockchain/sync_manager/src/sync.rs Outdated Show resolved Hide resolved
vm/actor/src/lib.rs Outdated Show resolved Hide resolved
@dutterbutter dutterbutter merged commit 67ebaae into master Feb 11, 2020
@dutterbutter dutterbutter deleted the dustin/check-msg branch February 11, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinabell austinabell austinabell approved these changes

@ec2 ec2 ec2 approved these changes

@ansermino ansermino ansermino approved these changes

@RajarupanSampanthan RajarupanSampanthan Awaiting requested review from RajarupanSampanthan

Assignees
No one assigned
Labels
Blockchain Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Message Check
4 participants
@dutterbutter @ec2 @ansermino @austinabell