Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor keypair retrieval and saving #221

Merged
merged 4 commits into from
Feb 11, 2020
Merged

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Issues found when working with network tests, keypair should not be automatically persisted when a keypair is not found. There was some janky logic that I wanted to clean up as well.
    • Essentially the problem is that a keypair is automatically pulled from keystore and used when generating new Libp2pService
  • Cleaned up tests that unnecessarily heap allocated bytes and handled errors specifically in the test (found in Remove TODO rename old file to keypair.old(?) #217)

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell merged commit 59e2fc7 into master Feb 11, 2020
@austinabell austinabell deleted the austin/keypair/ref branch February 11, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants