State Manager and initial miner retrieval methods #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutterbutter
requested review from
ansermino,
austinabell and
ec2
as code owners
dutterbutter
changed the title
austinabell
suggested changes
Feb 13, 2020
austinabell
suggested changes
Feb 14, 2020
ansermino
reviewed
Feb 18, 2020
| @@ -233,6 +239,12 @@ impl<'a> Syncer<'a> { | |||
| // see https://github.com/filecoin-project/lotus/blob/master/chain/sync.go#L611 | |||
| header.check_block_signature(header.miner_address())?; | |||
|
|
|||
| // TODO: incomplete, still need to retrieve power in order to ensure ticket is the winner | |||
| let _slash = self.state_manager.miner_slashed(header.miner_address())?; | |||
There was a problem hiding this comment.
Why do we check this? Can't correlate with spec
There was a problem hiding this comment.
Under Semantical Validation: must be from a valid miner, i.e. has not been slashed
There was a problem hiding this comment.
That doesn't appear in the current spec
There was a problem hiding this comment.
The spec uses the term 'plausible miner' which to me is the equivalent to 'valid miner' the term given in the link I posted above which uses slashing as an example of what makes a 'valid miner', and in lotus, it's being used for their block validation. I am happy to remove but I want to make sure I provide relevant information as to why I included it.
austinabell
suggested changes
Feb 20, 2020
austinabell
reviewed
Feb 20, 2020
austinabell
approved these changes
Feb 20, 2020
ec2
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
StateManagerand retrieval methods for state objectsStorageMinerActor,MinerInfoandStorageMinerActorStatestructures used to retrieve data about minersslashed_atandminer_sector_sizeto block validation methodReference issue to close (if applicable)
It does not close any particular task although it pushes #78 forward.
Other information and links
Block validation will remain incomplete until we implement missing VM components required to retrieve storage power, get a raw miner worker address and can validate miner.