Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cbor serialization formats and cleanup #228

Merged
merged 4 commits into from
Feb 18, 2020
Merged

Fix cbor serialization formats and cleanup #228

merged 4 commits into from
Feb 18, 2020

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Implement/ fix TxMeta (or message root) serialization to tuple serialization
  • Implement serialization of signed messages (will be important for signatures soon)
  • Cleaned up usages of a few small things for consistency
  • Adds cid function from block to access cid for block easier from header

These things were bugging me a bit and wanted to do now as we would need soon

Reference issue to close (if applicable)

Closes #143

Other information and links

@austinabell austinabell added Status: Needs Review encoding hashing and serialization labels Feb 13, 2020
dutterbutter
dutterbutter approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@dutterbutter dutterbutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@austinabell austinabell merged commit abe9be2 into master Feb 18, 2020
@austinabell austinabell deleted the austin/ser/cleanup branch February 18, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutterbutter dutterbutter dutterbutter approved these changes

@ansermino ansermino ansermino approved these changes

@GregTheGreek GregTheGreek Awaiting requested review from GregTheGreek

@RajarupanSampanthan RajarupanSampanthan Awaiting requested review from RajarupanSampanthan

@ec2 ec2 Awaiting requested review from ec2

Assignees
No one assigned
Labels
encoding hashing and serialization Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CBOR Encoding
3 participants
@austinabell @ansermino @dutterbutter