Refactor blockstore and Cid for usage #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ansermino,
dutterbutter and
ec2
as code owners
blockchain/sync_manager/Cargo.toml
Outdated
| @@ -10,16 +10,17 @@ amt = { package = "ipld_amt", path = "../../ipld/amt" } | |||
| blocks = { package = "forest_blocks", path = "../blocks" } | |||
| db = { path = "../../node/db" } | |||
| encoding = { package = "forest_encoding", path = "../../encoding" } | |||
| libp2p = { git = "https://github.com/SigP/rust-libp2p", rev = "776d13ef046358964c7d64cda3295a3a3cb24743" } | |||
| libp2p = { git = "https://github.com/SigP/rust-libp2p", rev = "776d13ef046358964c7d64cda3295a3a3cb24743" } | |||
There was a problem hiding this comment.
Shouldn't this be libp2p = "0.15.0"?
There was a problem hiding this comment.
yeah I didn't notice, this was auto formatted. Will swap. This must have come in after the swap to libp2p base
dutterbutter
approved these changes
Feb 14, 2020
|
Re-requested review since I also removed raw-block crate by updating the Cbor trait we use in encoding. Also removed dependency of Cid crate on our local encoding utility and seperated the serde stuff into a feature so now the Cid crate can very easily be upstreamed as is. |
ec2
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
This shouldn't cause any actual conflicts, maybe only minor if you were referencing blockstore in AMT crate or generating a cid from bytes default (I don't think that's the case for any of you guys rn)
Reference issue to close (if applicable)
Other information and links