Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
So since the serde macros don't call the associated variant of serialize, you can use a module in place of the type to serialize (similar to how serde_bytes works). This is important in future to not have to deploy/use a forked bigint dependency, cleaner for prod and makes easier to update dependency in the future. I have all bigint dependencies routing through this crate I created.
Downside to this is having to define a tuple type to annotate the serialization method. Another option is to later add a type to be able to convert to/from which could act as a proxy for serialization similar to how it is done currently when types need to be converted for serialization (I think the usage added in this PR is cleaner though).
Reference issue to close (if applicable)
Closes
Other information and links