Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cid serde feature reference #235

Merged
merged 2 commits into from
Feb 20, 2020
Merged

Fix cid serde feature reference #235

merged 2 commits into from
Feb 20, 2020

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Feb 19, 2020

Summary of changes
Changes introduced in this pull request:

  • Somehow this was not caught in the cargo check, build, or lint but is caught when running with cargo run -p forest. Might be worth adding cargo c -p forest to the CI since it works when compiling workspace as a whole because the serde feature gets compiled since the IPLD crate defines the serde_derive feature on Cid but the forest binary does not currently connect with IPLD yet.
  • Made serde_derive feature config more explicit on the serde implementations in Cid

Edit: Added cargo check -p forest to the CI so this doesn't happen again

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell changed the title Fix cid serde feature Fix cid serde feature reference Feb 19, 2020
@austinabell austinabell merged commit 1411572 into master Feb 20, 2020
@austinabell austinabell deleted the austin/fix/serdecid branch February 20, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants