ChainSync framework #243
Merged
ChainSync framework #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
added
Status: Needs Review
Blockchain
Network
austinabell
requested review from
ansermino,
dutterbutter and
ec2
as code owners
dutterbutter
suggested changes
Feb 27, 2020
dutterbutter
approved these changes
Feb 27, 2020
ec2
reviewed
Feb 28, 2020
|
|
||
| #[derive(Default)] | ||
| pub struct SyncManager { | ||
| sync_queue: SyncBucketSet, | ||
| } | ||
|
|
||
| impl SyncManager { | ||
| pub fn schedule_tipset(&mut self, tipset: Rc<Tipset>) { | ||
| pub fn schedule_tipset(&mut self, tipset: Arc<Tipset>) { |
ec2
reviewed
Feb 28, 2020
| use libp2p::core::PeerId; | ||
| use log::trace; | ||
|
|
||
| /// Context used in chain sync to handle sequential |
There was a problem hiding this comment.
I had it fixed on my local wip changes lol
ec2
reviewed
Feb 28, 2020
| /// Returns FullTipset from store if TipSetKeys exist in key-value store otherwise requests FullTipset | ||
| /// from block sync | ||
| pub fn fetch_tipset(&self, _peer_id: PeerId, tsk: &TipSetKeys) -> Result<FullTipset, Error> { | ||
| let fts = match self.load_fts(tsk) { |
There was a problem hiding this comment.
cant you just use ? instead of match? Just a nit dun matter
There was a problem hiding this comment.
not changed in this PR but the idea is leaving like this until the TODO is done (I commented the same thing on Dustin's PR)
ec2
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
ChainSyncera channel from the networking thread to this threadBlockSyncResponseincluding the tipset bundle and status code into a result with ok type being a full tipsetNetworkContextstruct to be able to handle RPC requests to the network and manage the request IDsIn this PR I've setup the ChainSyncer so that the underlying database and channels can be replaced from using a live db and p2p network to an in memory db and local channels for testing or replaced by anything else generic in the future. I will wait to write the actual integrated tests until the full structure is done, but I setup a test to make it easier to set that up if someone else does this.
There is some stuff still TODO, but as discussed I would open this PR as interim to hopefully allow others to build ontop of
Reference issue to close (if applicable)
Closes #223
Closes #227
Other information and links