Refactor RPC and implement hello protocol #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ansermino,
dutterbutter and
ec2
as code owners
dutterbutter
reviewed
Mar 2, 2020
node/forest_libp2p/src/rpc/mod.rs
Outdated
| @@ -51,3 +50,36 @@ impl std::fmt::Display for RPCEvent { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
For consistency should this be its own file error.rs?
| Blocksync(BlockSyncResponse), | ||
| Hello(HelloResponse), | ||
| } | ||
|
|
||
| /// Protocol upgrade for inbound RPC requests. Currently supports Blocksync. |
There was a problem hiding this comment.
Comment should be updated to include mention of hello protocol?
| impl RPCRequest { | ||
| pub fn supported_protocols(&self) -> Vec<&'static [u8]> { | ||
| match self { | ||
| // add more protocols when versions/encodings are supported |
node/forest_libp2p/src/service.rs
Outdated
| swarm_stream.get_mut().send_rpc(peer_id, RPCEvent::Response(1, RPCResponse::Blocksync(BlockSyncResponse { | ||
| chain: vec![], | ||
| status: 203, | ||
| message: "handling requests not implemented".to_owned(), | ||
| }))); | ||
| } | ||
| RPCEvent::Request(req_id, RPCRequest::Hello(message)) => { | ||
|
|
dutterbutter
approved these changes
Mar 2, 2020
|
This should also close #194 |
It has that in the PR description already :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
The hello protocol matches the spec definition but does not match lotus, lotus has only one Hello message type and has optional map fields that they serialize for both the request and response. It was a huge pain to try to retrieve their exact format so I will leave this for now but will probably have to switch it to match lotus to test our syncing functionality.
Reference issue to close (if applicable)
Closes #194
Other information and links