Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic cli #25

Merged
merged 7 commits into from
Nov 20, 2019
Merged

Add basic cli #25

merged 7 commits into from
Nov 20, 2019

Conversation

GregTheGreek
Copy link
Member

@GregTheGreek GregTheGreek commented Nov 19, 2019

Simple CLI setup.

To test:

  1. cargo run --bin node
  2. ./target/debug/node --help

ansermino
ansermino previously approved these changes Nov 19, 2019
Copy link
Member

@ansermino ansermino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Any thoughts where to go from here for this?

@austinabell
Copy link
Contributor

to resolve conflicts you can just remove all dependencies except clap

@GregTheGreek
Copy link
Member Author

@ansermino Yeah ill chat about it in slack

node/cli/cli.rs Outdated Show resolved Hide resolved
austinabell
austinabell previously approved these changes Nov 19, 2019
node/src/cli/mod.rs Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@GregTheGreek GregTheGreek requested review from austinabell and ansermino and removed request for austinabell November 19, 2019 22:44
@GregTheGreek GregTheGreek dismissed stale reviews from austinabell and ansermino November 19, 2019 22:45

CHANGES

@GregTheGreek GregTheGreek mentioned this pull request Nov 19, 2019
Copy link
Member

@ec2 ec2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GregTheGreek GregTheGreek merged commit 29c8b44 into master Nov 20, 2019
@GregTheGreek GregTheGreek deleted the greg/cli branch November 20, 2019 15:38
vmx pushed a commit to dignifiedquire/forest that referenced this pull request Mar 19, 2020
* feat(compute blake2b checksum after sealing and persist to metadata)

* feat(add stubbed sealed sector status to get_sealed_sectors response-struct)

* feat(plumb stubbed sealed sector healthcheck option through various APIs)

* refactor(get a little more-verbose with seal logger)

* feat(compute checksums in parallel using workers from rayon global thread pool)

* feat(update FFI test to exercise new API)

* refactor(add health check to FFI test suite and refactor helper)

* refactor(replace with assert_ne!)

* feat(handle missing file)

* refactor(move max number of staged sectors config into... TestConfig)

* refactor(drop pub scope)

* refactor(add better comment)

* refactor(fix import ordering)

* refactor(move duplication into symbol)

* refactor(avoid the clone)

* refactor(add checksum benchmark from original branch)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants