Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multihash dependency and Blockstore interface #253

Merged
merged 5 commits into from
Mar 5, 2020

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Updates to completely new API of multihash
  • Update function name which generates Cid from cbor encoded bytes
    • Cid::from_bytes() is kinda misleading as it insinuates it is just deserializing a Cid, when it is in fact generating a new one
  • Updates blockstore put to pass in the hash type to allow using other hash types for Cid generation (needed by Erlich)

Reference issue to close (if applicable)

Closes

Other information and links

Copy link
Member

@ec2 ec2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this

@austinabell austinabell merged commit bd9f5cf into master Mar 5, 2020
@austinabell austinabell deleted the austin/multihashbump branch March 5, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants