Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runtime to new spec/ impl #256

Merged
merged 2 commits into from
Mar 11, 2020
Merged

Update runtime to new spec/ impl #256

merged 2 commits into from
Mar 11, 2020

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Update runtime interface
    • Has changed a lot since I touched last lol. Hard to guess the exact usage or when the runtime will need to be mutable, and I will think a bit more into the exact usage but this will probably just act as a template to be updated when needed

The actors spec/ shared module is A LOT better than the spec was before, and although it might be painful to switch over now, the work can be very contained and easily worked on in parallel with coordination

Please give opinions on the API, I will think through more but this was just a quick pass so we can have something to quickly work off of

Reference issue to close (if applicable)

Closes #180

Other information and links

@ec2
Copy link
Member

ec2 commented Mar 10, 2020

LGTM! Looks like you missed some of the methods in the runtime though such as ValidateImmediateCallerAcceptAnyOfTypes

@austinabell
Copy link
Contributor Author

LGTM! Looks like you missed some of the methods in the runtime though such as ValidateImmediateCallerAcceptAnyOfTypes

Chatted in person but to answer I am basing off of the specs-actors, which this doesn't exist anymore

@austinabell austinabell merged commit 17a447e into master Mar 11, 2020
@austinabell austinabell deleted the austin/vmref branch March 11, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Runtime Interface based on spec changes
3 participants