Remove unnecessary db trait #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ansermino,
dutterbutter and
ec2
as code owners
ec2
reviewed
Mar 14, 2020
| @@ -42,7 +41,7 @@ impl Default for MemoryDB { | |||
|
|
|||
| impl DatabaseService for MemoryDB {} | |||
|
|
|||
| impl Write for MemoryDB { | |||
| impl Store for MemoryDB { | |||
There was a problem hiding this comment.
Whats the reason for collapsing Write and Read into Store?
There was a problem hiding this comment.
Annoying to reference both, no benefit for them being separated, conflicting trait name with io read and write
ec2
approved these changes
Mar 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links