Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean actors and update to spec #279

Merged
merged 11 commits into from
Mar 16, 2020
Merged

Clean actors and update to spec #279

merged 11 commits into from
Mar 16, 2020

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Mar 14, 2020

Summary of changes
Changes introduced in this pull request:

  • Spec has changed quite a bit so refactoring to match
    • Reorganized and exported the actor modules instead of exporting each type from the root level (more contained access because the amount of types was getting to be a lot)
  • Implemented serde traits for state which is defined already and was not implemented or incorrectly implemented

These changes will make it a lot easier for any of the actors to be worked on in isolation and not require conflicts when working in parallel. I tried to clean up and setup as much as possible, but did not go very in depth on purpose. I just made sure what exists isn't still from outdated spec or misleading.

Edit: Also implements account actor. I was going to make that seperate but it required more changes to the other actors than itself so didn't make sense to have these changes be reverted in next PR

Reference issue to close (if applicable)

Closes #261

Other information and links

@austinabell austinabell merged commit 5d82917 into master Mar 16, 2020
@austinabell austinabell deleted the austin/vm/actclean branch March 16, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement updated account actor
3 participants