Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Forest when using a config file to run calibnet #2796

Merged
merged 12 commits into from
Apr 27, 2023

Conversation

elmattic
Copy link
Contributor

@elmattic elmattic commented Apr 25, 2023

Summary of changes

Changes introduced in this pull request:

  • Add a proper enum for representing network chain
  • Fix Forest when using toml file to run calibnet
  • Disallow usage of flags --config and --chain at the same time

Reference issue to close (if applicable)

Closes

Other information and links

Related to issue we are facing in #2367 (comment)

Note the reason we need the fix on main branch is because the benchmark script is always compiling a fresh version of forest using main.

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

networks/src/lib.rs Outdated Show resolved Hide resolved
@elmattic elmattic merged commit c5656ae into main Apr 27, 2023
13 checks passed
@elmattic elmattic deleted the elmattic/fix-config-selection branch April 27, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants