Implement balance table #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ansermino,
dutterbutter and
ec2
as code owners
ec2
reviewed
Mar 19, 2020
| /// assert_eq!(total, 3); | ||
| /// ``` | ||
| #[inline] | ||
| pub fn for_each<F, V>(&self, f: &mut F) -> Result<(), String> |
There was a problem hiding this comment.
couldn't impl the Iterator trait instead?
There was a problem hiding this comment.
no because all of the elements are not in memory. Also this would be done on top of this, the reason for this is to be able to more closely match the spec.
ec2
reviewed
Mar 19, 2020
| @@ -129,6 +128,29 @@ where | |||
| self.pointers.is_empty() | |||
| } | |||
|
|
|||
| pub(crate) fn for_each<V, S, F>(&self, store: &S, f: &mut F) -> Result<(), String> | |||
There was a problem hiding this comment.
couldn't impl the Iterator trait instead?
ec2
approved these changes
Mar 19, 2020
dutterbutter
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
for_eachfunction on the hamt, which allows passing a function which reads kvs and performs the function on all of them while mutating state outside of the function.Reference issue to close (if applicable)
Closes #278
Other information and links