Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial chainsync process #293

Merged
merged 29 commits into from
Apr 7, 2020
Merged

Initial chainsync process #293

merged 29 commits into from
Apr 7, 2020

Conversation

dutterbutter
Copy link
Contributor

@dutterbutter dutterbutter commented Mar 20, 2020 •
edited

Summary of changes
Changes introduced in this pull request:

  • Added sync entry from main
  • Updating sync states
  • Initial logic for follow up sync state in place
  • Fetch full tipset for initial checkpoint and begins syncing headers reverse from there
  • Sync messages from blocksync functionality added
  • Moved common chain structure construction for tests into its own module
  • Added unit tests to sync.rs

Reference issue to close (if applicable)

Closes #249 #298

Other information and links

@dutterbutter
Ported over branch code
73c6e7b 
* Added sync manager to ChainSyncer
* Added Ord to types
@dutterbutter
Merge branch 'master' of github.com:ChainSafe/forest into dustin/chai…
c35d82d 
…nsyncer
@dutterbutter
Updated ChainSyncer to include bucketing
3c64c1e
@dutterbutter
Initial chainsync implemented
21ea035 
* Added Syncstates
* Made comments
* Fix error handelling
@dutterbutter dutterbutter reopened this Mar 21, 2020
austinabell
austinabell suggested changes Mar 21, 2020
View reviewed changes
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interop testing status? Hard to check specific logic

blockchain/chain_sync/src/bucket.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/bucket.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/bucket.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/network_context.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/peer_manager.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/sync.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/sync.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/sync.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/sync.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/sync.rs Outdated Show resolved Hide resolved
@dutterbutter
Copy link
Contributor Author

Interop testing status? Hard to check specific logic

I was not able to get the lotus node working myself, I have raised the question in the fil-help slack channel. I will follow up and update the status once i hear back.

@dutterbutter dutterbutter mentioned this pull request Mar 25, 2020
Closed
austinabell
austinabell reviewed Mar 27, 2020
View reviewed changes
Makefile Outdated Show resolved Hide resolved
blockchain/blocks/src/tipset.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/bucket.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/bucket.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/bucket.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/network_context.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/network_context.rs Outdated Show resolved Hide resolved
node/forest_libp2p/src/config.rs Show resolved Hide resolved
austinabell
austinabell suggested changes Apr 2, 2020
View reviewed changes
blockchain/chain/src/store/chain_store.rs Outdated Show resolved Hide resolved
blockchain/chain/src/store/chain_store.rs Outdated Show resolved Hide resolved
blockchain/chain/src/store/chain_store.rs Outdated Show resolved Hide resolved
blockchain/chain/src/store/chain_store.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/Cargo.toml Outdated Show resolved Hide resolved
blockchain/chain_sync/src/sync.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/sync.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/sync.rs Outdated Show resolved Hide resolved
utils/test_utils/Cargo.toml Show resolved Hide resolved
utils/test_utils/Cargo.toml Outdated Show resolved Hide resolved
austinabell
austinabell suggested changes Apr 7, 2020
View reviewed changes
blockchain/blocks/tests/tipset_tests.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/bucket.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/sync.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/sync.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/sync.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/sync.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/sync.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/sync.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/sync.rs Show resolved Hide resolved
utils/test_utils/src/chain_structures.rs Show resolved Hide resolved
@dutterbutter dutterbutter merged commit 4aacd72 into master Apr 7, 2020
@dutterbutter dutterbutter deleted the dustin/chainsyncer branch April 7, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinabell austinabell austinabell approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@ec2 ec2 Awaiting requested review from ec2

Assignees
No one assigned
Labels
Blockchain Status: Needs Changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Basic Sync Manager
3 participants
@dutterbutter @ec2 @austinabell