Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitfield/ rle+ impl #296

Merged
merged 4 commits into from
Mar 24, 2020
Merged

Bitfield/ rle+ impl #296

merged 4 commits into from
Mar 24, 2020

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Mar 22, 2020

Summary of changes
Changes introduced in this pull request:

  • Adds bitfield with RLE+ encoding through serde cbor serialize and deserialize implementations
    • Implementation was done by @dignifiedquire for the RLE+ encoding and decoding, I just updated to follow new protocol (encoding version), bumped versions, and implemented serde traits

The BitVec API is good but follows the Vec interface very closely where setting bits it will panic when out of range so when using you have to resize manually when necessary

Reference issue to close (if applicable)

Closes #276

Other information and links

@austinabell austinabell merged commit c97033c into master Mar 24, 2020
@austinabell austinabell deleted the austin/rleplus branch March 24, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement or connect existing RLE bitfield
3 participants