[VM] Implement basic message types and signing stubs #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ec2,
ansermino,
GregTheGreek and
dutterbutter
Closed
ansermino
reviewed
Nov 25, 2019
vm/src/message/mod.rs
Outdated
| pub(crate) method: u64, | ||
| pub(crate) params: Vec<u8>, | ||
|
|
||
| pub(crate) gas_price: BigUint, // change these to big int |
austinabell
changed the title
dutterbutter
suggested changes
Nov 25, 2019
vm/src/message/mod.rs
Outdated
| pub(crate) from: Address, | ||
| pub(crate) to: Address, | ||
|
|
||
| pub(crate) nonce: u64, |
There was a problem hiding this comment.
I don't see nonce defined in the spec for Message type?
There was a problem hiding this comment.
its sequence, which is why I was asking about standardizing this name since other implementations have this field as nonce
vm/src/message/mod.rs
Outdated
|
|
||
| pub(crate) value: BigUint, | ||
|
|
||
| pub(crate) method: u64, |
There was a problem hiding this comment.
Can we rename this field to method_id rather than method?
ec2
reviewed
Nov 25, 2019
| #[derive(PartialEq, Clone)] | ||
| pub struct MessageReceipt { | ||
| // TODO: determine if this is necessary, code returned from cbor | ||
| pub(crate) exit_code: u8, |
There was a problem hiding this comment.
may want to enum this in the future. but should be ok for now
ec2
approved these changes
Nov 25, 2019
ansermino
approved these changes
Nov 25, 2019
dutterbutter
approved these changes
Nov 25, 2019
vmx
pushed a commit
to dignifiedquire/forest
that referenced
this pull request
Mar 19, 2020
* feat(upgrade toolchain to match rust-fil-proofs) * fixup(point crates at Git branches during dev) * feat(consume new 0.6.0 releases) * feat(install paramcache from HEAD of master branch and compute Groth parameters) * feat(use chatty logging to see what's going on with sector builder) * feat(force install so that we don't explode if the binary already exists) * feat(consume new 0.6.1 patch release) * refactor(edits to accommodate new rust toolchain version) * feat(bump filecoin-proofs-ffi crate dependency)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will split TODO items into other issues to keep PRs small. Reason for me making currently unused fields as public to the crate is because I don't know exactly how they will be used so do not want to flood the method with getters but do not want to expose it publicly until I figure out exactly how they are used.