feat: add save_to_file option to cli state fetch
#3148
Conversation
hanabi1224
changed the title
cli sate fetchcli state fetch
hanabi1224
force-pushed
the
hm/state-fetch-save-to-file
branch
from
646f215
to
b959b25
Compare
hanabi1224
changed the title
cli state fetchsave_to_file option to cli state fetch
hanabi1224
force-pushed
the
hm/state-fetch-save-to-file
branch
4 times, most recently
from
b562291
to
76eff57
Compare
hanabi1224
force-pushed
the
hm/state-fetch-save-to-file
branch
from
76eff57
to
8a16243
Compare
hanabi1224
requested review from
elmattic,
lemmih,
LesnyRumcajs,
jdjaustin,
creativcoder,
sudo-shashank,
aatifsyed and
ruseinov
as code owners
| with: | ||
| go-version: "^1.20" | ||
| - name: Install go-car | ||
| run: go install github.com/ipld/go-car/cmd/car@v0.0.0-20230704002448-4de031a1d8a8 |
There was a problem hiding this comment.
I like this versioning. Very agile.
There was a problem hiding this comment.
It's recommended to use @latest locally but I would rather use a fixed version on CI
There was a problem hiding this comment.
Yeah, I was just mocking the 0.0.0 version. You cant' have any expectations in such a case. :)
| echo "Verifying saved .car file" | ||
| car verify bafy2bzacedjq7lc42qhlk2iymcpjlanntyzdupc3ckg66gkca6plfjs5m7euo.car | ||
| echo "Inspecting saved .car file" | ||
| car inspect bafy2bzacedjq7lc42qhlk2iymcpjlanntyzdupc3ckg66gkca6plfjs5m7euo.car |
There was a problem hiding this comment.
I'd put it into a separate file. The reason is, it needs a separate binary and I would like to be able to run ./scripts/tests/calibnet_other_checks.sh without it. Alternatively, I'm good with it if we could have it in a docker image (we'd avoid a Go dependency in the workflow this way)
There was a problem hiding this comment.
Moved out of test script
.github/workflows/forest.yml
Outdated
| run: | | ||
| # File name is hard-coded in ./scripts/tests/calibnet_other_check.sh | ||
| car verify bafy2bzacedjq7lc42qhlk2iymcpjlanntyzdupc3ckg66gkca6plfjs5m7euo.car | ||
| car inspect bafy2bzacedjq7lc42qhlk2iymcpjlanntyzdupc3ckg66gkca6plfjs5m7euo.car |
There was a problem hiding this comment.
What's the value of car inspect? Can it fail even after car verify has succeeded? If it's only used for debugging then let's remove it.
Summary of changes
As part of #3081
Changes introduced in this pull request:
state fetchto save the DAG to a fileReference issue to close (if applicable)
Closes
Other information and links
Change checklist