Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VM] Address module cleanup #32

Merged
merged 2 commits into from
Nov 25, 2019
Merged

[VM] Address module cleanup #32

merged 2 commits into from
Nov 25, 2019

Conversation

austinabell
Copy link
Contributor

  • Moves public crate tests of address to tests directory (agreed upon that private function tests can be module inside crate but public tests should go in tests directory)
  • Changes return type of function that does not return an Error

@austinabell austinabell changed the title Address module cleanup [VM] Address module cleanup Nov 25, 2019
@austinabell austinabell merged commit 62194eb into master Nov 25, 2019
@austinabell austinabell deleted the austin/addresscleanup branch November 25, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ec2 ec2 ec2 approved these changes

@ansermino ansermino ansermino approved these changes

@dutterbutter dutterbutter dutterbutter approved these changes

@GregTheGreek GregTheGreek Awaiting requested review from GregTheGreek

Assignees
No one assigned
Labels
Status: Needs Review VM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@austinabell @ec2 @ansermino @dutterbutter