feat: read and write support for forest.car.zst files #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
aatifsyed
force-pushed
the
aatifsyed/index-compressed-cars
branch
from
eae9728
to
213c80c
Compare
lemmih
requested review from
LesnyRumcajs and
elmattic
and removed request for
a team
elmattic
approved these changes
Jul 26, 2023
LesnyRumcajs
approved these changes
Jul 26, 2023
| @@ -0,0 +1,66 @@ | |||
| // Copyright 2019-2023 ChainSafe Systems | |||
There was a problem hiding this comment.
Is this benchmark compiled in the CI?
There was a problem hiding this comment.
It is not. :( We'll fix that in a follow-up PR.
| impl CarIndexBuilder { | ||
| // Number of buckets given `len` number of elements | ||
| pub fn capacity_at(len: usize) -> usize { | ||
| len * 100 / 81 |
There was a problem hiding this comment.
It's not clear where are those numbers coming from to me.
There was a problem hiding this comment.
It's the load-factor. I'll add some more documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
snapshot compresscommand for generating.forest.car.zstfiles..car,.car.zstor.forest.car.zst.Reference issue to close (if applicable)
Closes
Other information and links
Change checklist